Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a weakref to the window that the EventFilter is attached to #1093

Merged
merged 1 commit into from
Jan 31, 2022
Merged

Use a weakref to the window that the EventFilter is attached to #1093

merged 1 commit into from
Jan 31, 2022

Conversation

corranwebster
Copy link
Contributor

Fixes #1081.

mdickinson
mdickinson approved these changes Jan 31, 2022
View reviewed changes
Copy link
Member

@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but it would be great to have a test for this.

@corranwebster
Copy link
Contributor Author

Right now a blunt test is that the test suite segfaults in PySide6 without this fix. I'll think through if there is a way to test this independently without either getting too hung up on implementation details and given the constraints of trying to test around object finalization.

@corranwebster
Copy link
Contributor Author

I've added an issue for testing, as I think it is a larger problem than just this PR: #1097

@corranwebster corranwebster merged commit a391281 into main Jan 31, 2022
@corranwebster corranwebster deleted the fix/window-event-filter-finalization branch January 31, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdickinson mdickinson mdickinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failure to close dialog causing segfaults
2 participants
@corranwebster @mdickinson